fix: render image borders in the layout painter#429
Conversation
Co-authored-by: Jan Kubica <jan-kubica@users.noreply.github.com>
|
Warning Review limit reached
Next review available in: 54 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request ports image border rendering through layout painting by introducing border attributes (borderWidth, borderColor, borderStyle) to the layout engine types, preserving them during document conversion, and implementing border painting in the layout painter. The review feedback highlights a critical issue where borders applied directly to cropped elements are clipped and rendered invisible. To resolve this, the reviewer suggests updating applyImageBorder to accept generic HTMLElements and conditionally applying the border to the container element when cropping is active.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Cropped images clip a scaled <img> inside overflow:hidden, so borders on the image itself disappear. Apply borders to the crop container/wrapper instead, widen applyImageBorder to HTMLElement, and refresh the layout-engine API report. Co-authored-by: Jan Kubica <jan-kubica@users.noreply.github.com>
|
@coderabbitai review |
Image border attrs already lived on the ProseMirror image node (
borderWidth/borderColor/borderStyle), but the paged layout painter ignored them, so borders had no visual effect.Changes
ImageRun/ImageBlockborderStylenaming throughout