Added sensor pose read & write services#201
Open
jdsalmonson wants to merge 4 commits into
Open
Conversation
added 4 commits
September 25, 2017 22:16
Member
|
Hi Jay, thanks for your PR! I will review your proposal as soon as I find some free time. We would have to adapt it a little bit after PR #202 gets merged, since it adds a static tf broadcaster for publishing the sensor poses, and we would need to republish every time they are updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
In order to model my robot with your awesome STDR software, I needed to add the capability to query and change the sensor pose; my sensors are mounted on servos and thus are able to swivel back and forth. It works very nicely for my purposes and since it might be useful for others, I'm sending you a pull request with the implementation.
Thank you,
Jay