Support for Icechunk datasets on gcs#67
Open
Markusli wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technical Context
Description
Adds compatibility with GCS backed Icechunk repositories. Plugs into existing code so that if storage type is
gcs, Exception is not raised and opened dataset in is returned. Also adds support for optional keywords that specify the branch, tag or snapshot a user wants to open.To fit the pattern of existing tests I hosted a public empty dataset that is accessed when the test suite is run.
Checklist
README.mdto reflect any new environment variables, configuration changes, or breaking updates.AI tool usage
AI was used to help with test data preparation.