Skip to content

Emit otel metrics directly instead of through tracing#3623

Open
rylev wants to merge 1 commit into
mainfrom
direct-otel-metrics
Open

Emit otel metrics directly instead of through tracing#3623
rylev wants to merge 1 commit into
mainfrom
direct-otel-metrics

Conversation

@rylev

@rylev rylev commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Alternative to #3619

Instead of doing some compile time magic, we instead get rid of our dependency on tracing for emitting metrics and instead emit the otel metrics directly.

This does require duplicating macros to specify types as as far as I can tell we can't infer the type param we need to pass to the opentelemetry::metrics types.

I also deleted some tests in crates/connection-semaphore/src/lib.rs where were testing that we were emitting specific metrics. This is harder to test with the new implementation, and I'm not convinced we actually got that much out of those tests.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants