fix: update code for go-struct-converter release 0.2#289
Merged
Conversation
The release of 0.2.0 of go-struct-converter changed its API and broke this package. Update to use the function chains API. Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
Collaborator
|
The full set of changes are in the SPDX 3 branch, all of which except for the v3 related changes are required to support both forwards and backwards conversion: https://github.com/spdx/tools-golang/blob/spdx3/convert/chain.go#L17 To get this PR merged, both forwards and backwards conversion functionality needs to be included. I hadn't been planning on promoting to a full release until the SPDX 3 branch was merged, but I overlooked some changes to our release process that caused this, so if you are able to get to this before me, please just take the SPDX 2 related changes from that branch, or I can push some updates here if you like |
Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
sgaist
force-pushed
the
fix/adapt-to-go-struct-converter-0.2
branch
from
bec30ba to
6b58468
Compare
Contributor
Author
|
Sure thing ! If there is something else that I can help with, don't hesitate to ask. |
kzantow
reviewed
Jun 25, 2026
Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
sgaist
force-pushed
the
fix/adapt-to-go-struct-converter-0.2
branch
from
3178be8 to
2a5ef9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR updates the code to adapt to the backward incompatible changes that came with relase 0.2.1 from https://github.com/anchore/go-struct-converter/
Tickets and links
Fixes #288