Fix GetAllFilePaths slash prefix issue and resolve test failures from #263#281
Merged
Conversation
jijo-OO7
force-pushed
the
fix-getallfilepath
branch
from
a0d2af5 to
2728959
Compare
kzantow
reviewed
Mar 27, 2026
Signed-off-by: Suman Mandal <sumanmandal.intro@gmail.com>
jijo-OO7
force-pushed
the
fix-getallfilepath
branch
from
2728959 to
704e2f4
Compare
…sistent relative path handling Signed-off-by: Suman Mandal <sumanmandal.intro@gmail.com>
jijo-OO7
force-pushed
the
fix-getallfilepath
branch
from
704e2f4 to
a43ab39
Compare
Contributor
Author
|
@kzantow I've updated the implementation to use filepath.Abs(dirRoot) before the walk and removed the conditional prefix handling. Let me know if this looks good. |
Contributor
Author
|
Hey @kzantow just a friendly ping would like your review on this when you have a moment |
Contributor
Author
|
@kzantow could you have a look at this when you have moment . |
kzantow
reviewed
Jun 25, 2026
Signed-off-by: Suman Mandal <sumanmandal.intro@gmail.com>
kzantow
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #262
Normalize dirRoot using filepath.Abs before walking the directory to ensure
consistent path prefix handling for relative inputs such as ".".
Also updates tests by replacing t.Chdir with os.Chdir for compatibility with
older Go versions while preserving behavior.
Builds upon discussion in #263 and the earlier fix proposed by @OhioDschungel6.