Skip to content

Add truncate for names in sidebar pane#484

Open
marcincodes wants to merge 2 commits into
sofn-xyz:mainfrom
marcincodes:issue-446
Open

Add truncate for names in sidebar pane#484
marcincodes wants to merge 2 commits into
sofn-xyz:mainfrom
marcincodes:issue-446

Conversation

@marcincodes

@marcincodes marcincodes commented Sep 30, 2023

Copy link
Copy Markdown
Collaborator

Describe your changes

Truncate names that are overflowed

Screenshot 2023-09-30 at 16 56 58

Issue link

#446

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.

@changeset-bot

changeset-bot Bot commented Sep 30, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e0401fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Sep 30, 2023

Copy link
Copy Markdown

@marcincodes is attempting to deploy a commit to the sofn Team on Vercel.

A member of the Team first needs to authorize it.

@psugihara psugihara left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

@vercel

vercel Bot commented Oct 5, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mailing-dynamic-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 8:45pm
web-emails ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 8:45pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
mailing-web ⬜️ Ignored (Inspect) Visit Preview Oct 5, 2023 8:45pm

@psugihara

Copy link
Copy Markdown
Collaborator

I think there's a real test failure on this one, I re-ran a couple times.

@marcincodes

Copy link
Copy Markdown
Collaborator Author

Seems like I added a div and accessibility tool catch that this div is not accessible:

expected '<div.truncate>' to have attribute 'aria-selected'

I will fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants