Fix build on Haiku OS - #360
Closed
jedenastka wants to merge 1 commit into
Closed
Conversation
This disables async-process on Haiku OS, so smol as a whole is able to build. The same solution seems to be already in place for the espidf target, so I guess this should be okay.
Collaborator
|
Thanks for the PR, but the correct way to fix the issue is to fix async-signal. Filed smol-rs/async-signal#59. Looking at the error messages, it should be clear that those from Haiku and ESP-IDF are of entirely different natures. On Haiku (just lacking SIGIO): On ESP-IDF (lacking entirely sig*): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This disables async-process on Haiku OS, so smol as a whole is able to build. The same solution seems to be already in place for the espidf target, so I guess this should be okay.