Commit bdbc247
refactor(rt): drop batched Chronologer PredictRetentionTimeEquivalents override
The override ran batched Torch forward passes for speed, but its results
are not bit-identical to per-peptide prediction (~1e-7 drift from batched
BatchNorm/matmul), which broke two pre-existing exact-equality tests
(PredictRetentionTimeEquivalents_MatchesSinglePredictions and _LargeBatch)
and contradicted its own "results identical to PredictCore" doc.
It is not needed here: the method is declared on IRetentionTimePredictor
and implemented in the base RetentionTimePredictor, so Chronologer now
inherits the base implementation. The consumers (MetaMorpheus parallel
search RT calibration) call the interface method and keep working; only a
one-time calibration step loses the batched speedup. This file now matches
master. Batched inference can return as its own PR with tolerance tests.
Addresses nbollis #1036 review ("Is this method needed? ... use the existing method").
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 0a6b6b4 commit bdbc247
1 file changed
Lines changed: 0 additions & 78 deletions
File tree
- mzLib/Chromatography/RetentionTimePrediction/Chronologer
Lines changed: 0 additions & 78 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | 83 | | |
162 | 84 | | |
163 | 85 | | |
| |||
0 commit comments