add note about resources#296
Open
pwright wants to merge 1 commit into
Open
Conversation
hash-d
reviewed
Jun 23, 2026
| - A Secret containing a signing CA for site linking | ||
|
|
||
| The output resources generated by the controller belong to the | ||
| `internal.skupper.io` API group. The controller acts as the field |
Member
There was a problem hiding this comment.
I'm not sure what API group stands for, in this context. Also, a resource may have several field managers, for different sets of fields.
There are things, such as adding new labels or changing non-skupper labels that the user may be allowed to do.
I think I originally suggested mentioning that skupper works as a field manager for those resources, but on a second thought that's more noise than signal.
Perhaps we could tell them simply that they're allowed to add or change their own entries on metadata.annotations and metadata.labels (but not skupper's, as identified with internal.skupper.io), and that any changes done within spec.* are subject to be overwritten by the controller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.