Skip to content

SF-3833 Fix crash when selecting autocomplete entries#3984

Merged
Nateowami merged 1 commit into
masterfrom
fix/SF-3833
Jul 22, 2026
Merged

SF-3833 Fix crash when selecting autocomplete entries#3984
Nateowami merged 1 commit into
masterfrom
fix/SF-3833

Conversation

@pmachapman

@pmachapman pmachapman commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

I also fixed any other place I could see where this same bug could reoccur.


This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Jul 7, 2026
@pmachapman
pmachapman temporarily deployed to screenshot_diff July 7, 2026 02:15 — with GitHub Actions Inactive
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.06%. Comparing base (3e810df) to head (4a8920b).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3984   +/-   ##
=======================================
  Coverage   81.06%   81.06%           
=======================================
  Files         645      645           
  Lines       41551    41551           
  Branches     6766     6771    +5     
=======================================
  Hits        33685    33685           
  Misses       6754     6754           
  Partials     1112     1112           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Nateowami Nateowami left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Nateowami reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@Nateowami Nateowami left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Nateowami made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@Nateowami Nateowami self-assigned this Jul 15, 2026
@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Jul 16, 2026
@pmachapman
pmachapman temporarily deployed to screenshot_diff July 21, 2026 23:02 — with GitHub Actions Inactive
@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Jul 22, 2026
@Nateowami
Nateowami enabled auto-merge (squash) July 22, 2026 17:39
@Nateowami
Nateowami temporarily deployed to screenshot_diff July 22, 2026 17:53 — with GitHub Actions Inactive
@Nateowami
Nateowami merged commit 953012f into master Jul 22, 2026
25 of 26 checks passed
@Nateowami
Nateowami deleted the fix/SF-3833 branch July 22, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants