SF-3833 Fix crash when selecting autocomplete entries#3984
Merged
Conversation
pmachapman
temporarily deployed
to
screenshot_diff
July 7, 2026 02:15 — with
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3984 +/- ##
=======================================
Coverage 81.06% 81.06%
=======================================
Files 645 645
Lines 41551 41551
Branches 6766 6771 +5
=======================================
Hits 33685 33685
Misses 6754 6754
Partials 1112 1112 ☔ View full report in Codecov by Harness. |
Nateowami
approved these changes
Jul 15, 2026
Nateowami
left a comment
Collaborator
There was a problem hiding this comment.
@Nateowami reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
Nateowami
approved these changes
Jul 15, 2026
Nateowami
left a comment
Collaborator
There was a problem hiding this comment.
@Nateowami made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
pmachapman
temporarily deployed
to
screenshot_diff
July 21, 2026 23:02 — with
GitHub Actions
Inactive
Nateowami
enabled auto-merge (squash)
July 22, 2026 17:39
Nateowami
temporarily deployed
to
screenshot_diff
July 22, 2026 17:53 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also fixed any other place I could see where this same bug could reoccur.
This change is