SF-3841 Fix book order for quality estimation results#3983
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3983 +/- ##
==========================================
- Coverage 81.06% 81.06% -0.01%
==========================================
Files 645 645
Lines 41551 41551
Branches 6766 6771 +5
==========================================
- Hits 33685 33684 -1
- Misses 6754 6755 +1
Partials 1112 1112 ☔ View full report in Codecov by Harness. |
Nateowami
left a comment
There was a problem hiding this comment.
@Nateowami reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).
src/SIL.XForge.Scripture/Services/MachineApiService.cs line 1202 at r1 (raw file):
ProjectId = id[0], BuildId = id[1], BookConfidences = [.. draftMetrics.BookConfidences.OrderBy(c => c.BookNum)],
Only one concern: Is it possible for the chapters to be out of order as well? I'm guessing that would be less common, but maybe still possible?
Non-blocking.
pmachapman
left a comment
There was a problem hiding this comment.
@pmachapman made 1 comment and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
src/SIL.XForge.Scripture/Services/MachineApiService.cs line 1202 at r1 (raw file):
Previously, Nateowami wrote…
Only one concern: Is it possible for the chapters to be out of order as well? I'm guessing that would be less common, but maybe still possible?
Non-blocking.
Done. Good point, yes it is technically possible - fixed.
Nateowami
left a comment
There was a problem hiding this comment.
@Nateowami reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
This change is