Skip to content

SF-3841 Fix book order for quality estimation results#3983

Merged
Nateowami merged 1 commit into
masterfrom
fix/SF-3841
Jul 22, 2026
Merged

SF-3841 Fix book order for quality estimation results#3983
Nateowami merged 1 commit into
masterfrom
fix/SF-3841

Conversation

@pmachapman

@pmachapman pmachapman commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Jul 7, 2026
@pmachapman
pmachapman temporarily deployed to screenshot_diff July 7, 2026 01:09 — with GitHub Actions Inactive
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.06%. Comparing base (953012f) to head (c2118c8).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...SIL.XForge.Scripture/Services/MachineApiService.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3983      +/-   ##
==========================================
- Coverage   81.06%   81.06%   -0.01%     
==========================================
  Files         645      645              
  Lines       41551    41551              
  Branches     6766     6771       +5     
==========================================
- Hits        33685    33684       -1     
- Misses       6754     6755       +1     
  Partials     1112     1112              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Nateowami Nateowami left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Nateowami reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).


src/SIL.XForge.Scripture/Services/MachineApiService.cs line 1202 at r1 (raw file):

            ProjectId = id[0],
            BuildId = id[1],
            BookConfidences = [.. draftMetrics.BookConfidences.OrderBy(c => c.BookNum)],

Only one concern: Is it possible for the chapters to be out of order as well? I'm guessing that would be less common, but maybe still possible?

Non-blocking.

@Nateowami Nateowami self-assigned this Jul 15, 2026

@pmachapman pmachapman left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmachapman made 1 comment and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).


src/SIL.XForge.Scripture/Services/MachineApiService.cs line 1202 at r1 (raw file):

Previously, Nateowami wrote…

Only one concern: Is it possible for the chapters to be out of order as well? I'm guessing that would be less common, but maybe still possible?

Non-blocking.

Done. Good point, yes it is technically possible - fixed.

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Jul 19, 2026
@pmachapman
pmachapman temporarily deployed to screenshot_diff July 19, 2026 20:37 — with GitHub Actions Inactive

@Nateowami Nateowami left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Nateowami reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Jul 22, 2026
@Nateowami
Nateowami enabled auto-merge (squash) July 22, 2026 17:39
@Nateowami
Nateowami temporarily deployed to screenshot_diff July 22, 2026 18:03 — with GitHub Actions Inactive
@Nateowami
Nateowami merged commit a82c52e into master Jul 22, 2026
26 checks passed
@Nateowami
Nateowami deleted the fix/SF-3841 branch July 22, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants