Skip to content

test: verify upgrade drain honors grace period and aborts on failure #3227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
talos-bot merged 1 commit into from
Aug 10, 2026
Merged

test: verify upgrade drain honors grace period and aborts on failure #3227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 73 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,79 @@ jobs:
path: ${{ github.workspace }}/integration-test
retention-days: "5"
continue-on-error: true
e2e-drain-grace-period:
runs-on:
group: large
if: contains(fromJSON(needs.default.outputs.labels || '[]'), 'integration/e2e')
|| contains(fromJSON(needs.default.outputs.labels || '[]'), 'integration/e2e-drain')
needs:
- integration-talemu
- integration-qemu
- e2e-qemu
- e2e-talemu
- e2e-auth0
- e2e-saml
- e2e-helm
steps:
- name: gather-system-info
id: system-info
uses: kenchan0130/actions-system-info@59699597e84e80085a750998045983daa49274c4 # version: v1.4.0
continue-on-error: true
- name: print-system-info
run: |
MEMORY_GB=$((${{ steps.system-info.outputs.totalmem }}/1024/1024/1024))

OUTPUTS=(
"CPU Core: ${{ steps.system-info.outputs.cpu-core }}"
"CPU Model: ${{ steps.system-info.outputs.cpu-model }}"
"Hostname: ${{ steps.system-info.outputs.hostname }}"
"NodeName: ${NODE_NAME}"
"Kernel release: ${{ steps.system-info.outputs.kernel-release }}"
"Kernel version: ${{ steps.system-info.outputs.kernel-version }}"
"Name: ${{ steps.system-info.outputs.name }}"
"Platform: ${{ steps.system-info.outputs.platform }}"
"Release: ${{ steps.system-info.outputs.release }}"
"Total memory: ${MEMORY_GB} GB"
)

for OUTPUT in "${OUTPUTS[@]}";do
echo "${OUTPUT}"
done
continue-on-error: true
- name: checkout
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # version: v7.0.0
- name: Unshallow
run: |
git fetch --prune --unshallow
- name: Set up Docker Buildx
id: setup-buildx
uses: docker/setup-buildx-action@bb05f3f5519dd87d3ba754cc423b652a5edd6d2c # version: v4.2.0
with:
driver: remote
endpoint: tcp://buildkit-amd64.ci.svc.cluster.local:1234
timeout-minutes: 10
- name: Mask secrets
run: |
echo "$(sops -d .secrets.yaml | yq -e '.secrets | to_entries[] | "::add-mask::" + .value')"
- name: Set secrets for job
run: |
sops -d .secrets.yaml | yq -e '.secrets | to_entries[] | .key + "=" + .value' >> "$GITHUB_ENV"
- name: run-integration-qemu
env:
INTEGRATION_TEST_ARGS: --test.run TestIntegration/Suites/(CleanState|DrainTerminationGracePeriod)$
TEST_CLASS: integration-qemu
WITH_DEBUG: "true"
WITH_RACE: "true"
run: |
sudo -E make run-integration-test
- name: save-integration-qemu-artifacts
if: always()
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # version: v7.0.1
with:
name: integration-qemu-e2e-drain-grace-period
path: ${{ github.workspace }}/integration-test
retention-days: "5"
continue-on-error: true
e2e-enterprise:
runs-on:
group: large
Expand Down
74 changes: 74 additions & 0 deletions .github/workflows/e2e-drain-grace-period-cron.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
# THIS FILE WAS AUTOMATICALLY GENERATED BY KRES, PLEASE DO NOT EDIT.
#
# Generated on 2026-08-05T11:13:11Z by kres 93d28ca.

concurrency:
group: ${{ github.head_ref || github.run_id }}
cancel-in-progress: true
'on':
schedule:
- cron: 30 1 * * *
name: e2e-drain-grace-period-cron
jobs:
default:
runs-on:
group: large
steps:
- name: gather-system-info
id: system-info
uses: kenchan0130/actions-system-info@59699597e84e80085a750998045983daa49274c4 # version: v1.4.0
continue-on-error: true
- name: print-system-info
run: |
MEMORY_GB=$((${{ steps.system-info.outputs.totalmem }}/1024/1024/1024))

OUTPUTS=(
"CPU Core: ${{ steps.system-info.outputs.cpu-core }}"
"CPU Model: ${{ steps.system-info.outputs.cpu-model }}"
"Hostname: ${{ steps.system-info.outputs.hostname }}"
"NodeName: ${NODE_NAME}"
"Kernel release: ${{ steps.system-info.outputs.kernel-release }}"
"Kernel version: ${{ steps.system-info.outputs.kernel-version }}"
"Name: ${{ steps.system-info.outputs.name }}"
"Platform: ${{ steps.system-info.outputs.platform }}"
"Release: ${{ steps.system-info.outputs.release }}"
"Total memory: ${MEMORY_GB} GB"
)

for OUTPUT in "${OUTPUTS[@]}";do
echo "${OUTPUT}"
done
continue-on-error: true
- name: checkout
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # version: v7.0.0
- name: Unshallow
run: |
git fetch --prune --unshallow
- name: Set up Docker Buildx
id: setup-buildx
uses: docker/setup-buildx-action@bb05f3f5519dd87d3ba754cc423b652a5edd6d2c # version: v4.2.0
with:
driver: remote
endpoint: tcp://buildkit-amd64.ci.svc.cluster.local:1234
timeout-minutes: 10
- name: Mask secrets
run: |
echo "$(sops -d .secrets.yaml | yq -e '.secrets | to_entries[] | "::add-mask::" + .value')"
- name: Set secrets for job
run: |
sops -d .secrets.yaml | yq -e '.secrets | to_entries[] | .key + "=" + .value' >> "$GITHUB_ENV"
- name: run-integration-qemu
env:
INTEGRATION_TEST_ARGS: --test.run TestIntegration/Suites/(CleanState|DrainTerminationGracePeriod)$
TEST_CLASS: integration-qemu
WITH_DEBUG: "true"
WITH_RACE: "true"
run: |
sudo -E make run-integration-test
- name: save-integration-qemu-artifacts
if: always()
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # version: v7.0.1
with:
name: integration-qemu
path: ${{ github.workspace }}/integration-test
retention-days: "5"
3 changes: 2 additions & 1 deletion .github/workflows/slack-notify-ci-failure.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# THIS FILE WAS AUTOMATICALLY GENERATED BY KRES, PLEASE DO NOT EDIT.
#
# Generated on 2026-07-09T13:52:50Z by kres 14a38a3.
# Generated on 2026-08-05T11:13:11Z by kres 93d28ca.

'on':
workflow_run:
Expand All @@ -19,6 +19,7 @@
- e2e-cluster-import-cron
- e2e-minor-talos-upgrade-cron
- e2e-rotate-ca-cron
- e2e-drain-grace-period-cron
- e2e-enterprise-cron
types:
- completed
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/slack-notify.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# THIS FILE WAS AUTOMATICALLY GENERATED BY KRES, PLEASE DO NOT EDIT.
#
# Generated on 2026-07-09T13:52:50Z by kres 14a38a3.
# Generated on 2026-08-05T11:13:11Z by kres 93d28ca.

'on':
workflow_run:
Expand All @@ -19,6 +19,7 @@
- e2e-cluster-import-cron
- e2e-minor-talos-upgrade-cron
- e2e-rotate-ca-cron
- e2e-drain-grace-period-cron
- e2e-enterprise-cron
types:
- completed
Expand Down
13 changes: 13 additions & 0 deletions .kres.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,19 @@ spec:
skipArtifactDownload: true
environmentOverride:
INTEGRATION_TEST_ARGS: "--test.run TestIntegration/Suites/(CleanState|RotateCA)$"
- name: e2e-drain-grace-period
needsOverride:
[integration-talemu, integration-qemu, e2e-qemu, e2e-talemu, e2e-auth0, e2e-saml, e2e-helm]
crons:
- "30 1 * * *"
runnerGroup: large
triggerLabels:
- integration/e2e
- integration/e2e-drain
artifacts:
skipArtifactDownload: true
environmentOverride:
INTEGRATION_TEST_ARGS: "--test.run TestIntegration/Suites/(CleanState|DrainTerminationGracePeriod)$"
- name: e2e-enterprise
needsOverride:
[integration-talemu, integration-qemu, e2e-qemu, e2e-talemu, e2e-auth0, e2e-saml, e2e-helm]
Expand Down
Loading
Loading