feat: add machine log ingestion byte-rate metric#3106
Merged
talos-bot merged 1 commit intoJul 10, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a Prometheus metric to track the byte volume of machine logs accepted for ingestion, enabling dashboards/alerting to calculate an effective ingestion Bps rate for the existing rate-limiting behavior (resolves #3095).
Changes:
- Add
omni_machine_logs_ingested_bytes_totalcounter toLogHandlerand expose it via Prometheus collector registration. - Add unit tests validating the metric increments only for messages that pass the rate limiter.
- Extend the Grafana “omni-details” dashboard with panels for log ingestion Bps and dropped-bytes Bps.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/pkg/siderolink/loghandler.go | Adds ingested-bytes counter, implements Prometheus collector on LogHandler, and increments metric during message handling. |
| internal/pkg/siderolink/loghandler_test.go | Adds tests for the new ingested-bytes metric behavior with/without the limiter. |
| hack/compose/grafana/dashboards/omni-details.json | Adds a new “Machine Logs” dashboard row with ingestion and dropped-bytes time series panels. |
| cmd/omni/pkg/app/app.go | Registers the LogHandler collector with Prometheus at app startup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Adds `omni_machine_logs_ingested_bytes_total`, a Prometheus counter on LogHandler that tracks the size of every machine log messages successfully written to storage. Signed-off-by: Oguz Kilcan <oguz.kilcan@siderolabs.com>
oguzkilcan
force-pushed
the
feat/machine-log-ingestion-metrics
branch
from
fecaaea to
a47e712
Compare
Unix4ever
approved these changes
Jul 10, 2026
Member
Author
|
/m |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
omni_machine_logs_ingested_bytes_total, a Prometheus counter on LogHandler that tracks the size of every machine log message accepted for ingestion.Resolves: #3095