Skip to content

Reference actions-setup-mysql version with a variable#11

Closed
pgporada wants to merge 3 commits into
shogo82148:mainfrom
pgporada:get-specific-actions-release-ver
Closed

Reference actions-setup-mysql version with a variable#11
pgporada wants to merge 3 commits into
shogo82148:mainfrom
pgporada:get-specific-actions-release-ver

Conversation

@pgporada

@pgporada pgporada commented Jun 12, 2026

Copy link
Copy Markdown

Thanks for taking a look. I'm ultimately trying to test go-sql-driver/mysql against MariaDB 12.3.x and 13.x in go-sql-driver/mysql#1774.

Summary by CodeRabbit

  • Chores
    • Updated build infrastructure to import MySQL/MariaDB artifacts from a newer upstream release (v1.51.0).

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The PR parameterizes the upstream actions-setup-mysql release version in import-builds.sh by introducing an ACTIONS_RELEASE_VER variable set to v1.51.0 and updating both MySQL and MariaDB artifact download URLs and GitHub release notes to use that variable instead of hardcoded v1.45.0 references.

Changes

Release version parameterization

Layer / File(s) Summary
Release version variable and artifact URLs
import-builds.sh
Introduces ACTIONS_RELEASE_VER="v1.51.0" and replaces hardcoded version strings in MySQL and MariaDB artifact download paths and gh release create --notes text with the parameterized variable.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A version variable hops into view,
From v1.45.0 to v1.51.0 anew,
MySQL and MariaDB dance in line,
Parameterized and looking so fine! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately summarizes the main change: introducing a variable to reference the actions-setup-mysql version instead of hardcoding it.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pgporada pgporada changed the title Use the latest actions-setup-mysql release and reference it with a variable Reference actions-setup-mysql version with a variable Jun 12, 2026
@shogo82148

Copy link
Copy Markdown
Owner

Thanks, but import-builds.sh is for temporary use and I don't use it for builds anymore.

@shogo82148 shogo82148 closed this Jun 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants