Skip to content

fix: install the latest major version of peer dependencies #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomdracz merged 2 commits into from
Jul 21, 2025
Merged

fix: install the latest major version of peer dependencies #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
567f59c
fix: install the latest major version of peer dependencies
G-Rath Jun 9, 2025
a63de55
docs: add changelog entry
G-Rath Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Changes since the last non-beta release.

### Fixed

- Install the latest major version of peer dependencies [PR 576](https://github.com/shakacode/shakapacker/pull/576) by [G-Rath](https://github.com/g-rath).
- Remove duplicate word in comment from generated `shakapacker.yml` config [PR 572](https://github.com/shakacode/shakapacker/pull/572) by [G-Rath](https://github.com/g-rath).

## [v8.3.0] - April 25, 2025
Expand Down
2 changes: 1 addition & 1 deletion lib/install/template.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def fetch_peer_dependencies
dev_dependencies_to_add = []

peers.each do |(package, version)|
major_version = version.match(/(\d+)/)[1]
major_version = version.split("||").last.match(/(\d+)/)[1]
entry = "#{package}@#{major_version}"

if dev_dependency_packages.include? package
Expand Down