Skip to content

[codex] Fix main CI generator dependency pin#1177

Closed
justin808 wants to merge 1 commit into
mainfrom
jg-codex/fix-main-ci
Closed

[codex] Fix main CI generator dependency pin#1177
justin808 wants to merge 1 commit into
mainfrom
jg-codex/fix-main-ci

Conversation

@justin808

Copy link
Copy Markdown
Member

Summary

  • format the agent workflow README so main's Prettier check passes
  • pin the generator e2e React template to @babel/preset-react@^7.0.0
  • add a guard spec so the template stays Node 20-compatible

Root cause

Main CI started resolving unpinned @babel/preset-react to a package path that pulls Babel 8-era helpers requiring newer Node than the generator workflow's Node 20.19.x runtime. The React install then failed, and the generated app later failed to compile because react/react-dom were missing.

Validation

  • yarn prettier --check .
  • .agents/bin/lint
  • .agents/bin/build
  • bundle exec rspec spec/generator_specs/generator_spec.rb:15
  • Node 20 CI-style generator repro for the failing npm and yarn_classic examples with SHAKAPACKER_NPM_PACKAGE set
  • git diff --check
  • autoreview clean

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 832920c4-4271-444f-b687-63840f96f739

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jg-codex/fix-main-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@justin808

Copy link
Copy Markdown
Member Author

Closing as superseded by the merged fixes: #1180 fixed the agent README formatting that was part of this draft, and #1167 merged the generator e2e dependency pin with a stronger React 18 + preset-react 7 constraint and full CI coverage. No separate issue work is included in this closeout wave.

@justin808 justin808 closed this Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant