Update CHANGELOG.md for v10.1.0#1139
Conversation
Stamp v10.1.0 stable release header (was v10.1.0-rc.2). Curate prerelease entries: - Merged PR #1133 into PR #1096's supplemental-packages entry; #1133 restructured the deps from direct to peer in rc.2, so the merged entry now describes the final shipped shape (required peer dependencies, auto-installed on npm 7+). - Merged PR #1132 into PR #1104's ESM binstubs entry; #1132 fixed the export_bundler_config dispatch regression that #1104 introduced in rc.1, and added NODE_ENV/RAILS_ENV mapping plus better non-Error CLI message printing. - Merged PR #1106 into PR #1086's local-path detection entry; both shipped in rc.0 as iterations of the same fix. - Updated Migration Notes to remove "bundled stack" language now that the supplementals declare peers instead of direct deps. - Updated compare links: [Unreleased] now points from v10.1.0; the v10.1.0-rc.2 compare link was replaced with v10.1.0. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughCHANGELOG.md updated to finalize v10.1.0 release (May 27, 2026) with revised Added/Changed/Fixed sections documenting supplemental npm packages, shakapacker:doctor checks, Rspack v2 defaults, React Refresh v2 compatibility, and various configuration fixes. Comparison links updated to target v10.1.0 as the release base. Changesv10.1.0 Release Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR promotes the v10.1.0-rc.2 prerelease CHANGELOG header to the stable
Confidence Score: 5/5Documentation-only change with no code modifications; safe to merge. The entire diff is limited to CHANGELOG.md — promoting the RC header to stable, folding related RC entries into consolidated stable entries, and updating the compare links at the bottom. All curated entries accurately reference the correct PRs, the peer-dependency description is consistent with the PR descriptions for #1133, and the [Unreleased]/[v10.1.0] compare links follow the existing Keep a Changelog pattern used by every prior release in the file. No code, configuration, or test files are touched. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["RC entries in CHANGELOG\n(v10.1.0-rc.2 header)"] --> B{Curation logic}
B --> C["Merge: PR #1096 + #1133\n→ single 'Added' entry\n(peer-dep shape)"]
B --> D["Merge: PR #1086 + #1106\n→ single 'Fixed' entry\n(local-path detection)"]
B --> E["Merge: PR #1104 + #1132\n→ single 'Fixed' entry\n(ESM binstubs)"]
B --> F["Remove: standalone\nPR #1133 'Changed' entry"]
B --> G["Remove: standalone\nPR #1132 'Fixed' entry"]
B --> H["Skip: PR #1138\n(internal tooling — not user-visible)"]
C --> I["Stable CHANGELOG\n## [v10.1.0] - May 25, 2026"]
D --> I
E --> I
I --> J["Update compare links\n[Unreleased]: v10.1.0...main\n[v10.1.0]: v10.0.0...v10.1.0"]
J --> K["Ready for\nbundle exec rake release"]
Reviews (1): Last reviewed commit: "Update CHANGELOG.md for v10.1.0" | Re-trigger Greptile |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b57d5f393
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ### Added | ||
|
|
||
| - **Added supplemental npm packages `shakapacker-webpack` and `shakapacker-rspack`**. [PR #1096](https://github.com/shakacode/shakapacker/pull/1096) by [justin808](https://github.com/justin808). Optional packages that lockstep with core and bundle the managed-build stack as direct `dependencies` (so a single `yarn add shakapacker-webpack` pulls in `shakapacker`, `webpack`, `webpack-cli`, and `webpack-assets-manifest`; the rspack package bundles `shakapacker`, `@rspack/core`, `@rspack/cli`, and `rspack-manifest-plugin`). Optional features (transpilers, dev-server, CSS preprocessors, react-refresh) remain as opt-in `peerDependencies` so SCSS/native-binding bloat isn't forced on every install. The wrappers emit structured warnings (`SHAKAPACKER_BUNDLER_MISMATCH`, `SHAKAPACKER_NO_TRANSPILER`) when `config.assets_bundler` or `javascript_transpiler` doesn't match the installed peers. See the [v10.1 migration guide](docs/migration/v10.1-supplemental-packages.md) for adoption steps and [`docs/dependency-strategy.md`](docs/dependency-strategy.md) for the design rationale and v11 roadmap. | ||
| - **Added supplemental npm packages `shakapacker-webpack` and `shakapacker-rspack`**. [PR #1096](https://github.com/shakacode/shakapacker/pull/1096), [PR #1133](https://github.com/shakacode/shakapacker/pull/1133) by [justin808](https://github.com/justin808). Optional packages that lockstep with core and declare the managed-build stack as required peer dependencies (so on npm 7+ a single `yarn add shakapacker-webpack` auto-installs `shakapacker`, `webpack`, `webpack-cli`, and `webpack-assets-manifest`; `shakapacker-rspack` declares `shakapacker`, `@rspack/core`, `@rspack/cli`, and `rspack-manifest-plugin`). Required peers eliminate the silent duplicate-bundler failure mode that direct dependencies could cause when an app or transitive dep pins a different bundler version. Optional features (transpilers, dev-server, CSS preprocessors, react-refresh) remain as opt-in `peerDependencies` so SCSS/native-binding bloat isn't forced on every install. The wrappers emit structured warnings (`SHAKAPACKER_BUNDLER_MISMATCH`, `SHAKAPACKER_NO_TRANSPILER`) when `config.assets_bundler` or `javascript_transpiler` doesn't match the installed peers. pnpm and Yarn PnP users should keep packages imported by app config files as explicit app dependencies (the Rails installer handles this automatically). See the [v10.1 migration guide](docs/migration/v10.1-supplemental-packages.md) for adoption steps and [`docs/dependency-strategy.md`](docs/dependency-strategy.md) for the design rationale and v11 roadmap. |
There was a problem hiding this comment.
This sentence ties peer auto-install behavior to npm 7+ but demonstrates it with yarn add, which is a different package manager path; that makes the release note internally inconsistent and can mislead users into expecting npm-specific behavior when running Yarn commands. Please align the condition and command (for example, npm condition with npm command, or Yarn-specific condition with Yarn command) so installation guidance is accurate.
Useful? React with 👍 / 👎.
Code Review — CHANGELOG.md for v10.1.0Overview: Documentation-only PR that promotes the What's correct
Minor observation (pre-existing, not introduced here)Line 45 reads "Fix rspack setup not reusing…" (present tense), while every other bullet in the Fixed section uses "Fixed …" (past tense). This predates this PR and is out of scope, but worth a quick cleanup pass in a follow-up. VerdictLGTM. The curation is accurate, the compare links are correct, and the consolidated entries give stable-release readers a clear picture without RC noise. Safe to merge once the release tag workflow is ready. |
Updated release date for version 10.1.0 and added details about new npm packages.
…nalyze-webpack-output * origin/main: (164 commits) Make Rspack the default bundler for new installs (#1150) Add "Why Shakapacker with Rspack" comparison guide (#1155) Support sass-loader v17 (#1141) [codex] Fix Claude workflow permissions (#1153) Fix README CI badges and add prominent docs link (#1152) Trim README into a docs-site index; relocate content to docs/ and fix deep links (#1148) Tighten helper binstub parity and PATH lookup (#1128) Optimize CI: minimal version matrix on PRs, full matrix on main (#1151) Fix instance-scoped compiler strategies (#1147) Fix Rspack devServer in static watch mode (#1142) Add homepage links for supplemental npm packages (#1145) Release 10.1.0 Update CHANGELOG.md for v10.1.0 (#1139) Expand prerelease-to-stable changelog coalesce guidance in /update-changelog (#1138) Release 10.1.0-rc.2 [codex] Update changelog for v10.1.0-rc.2 (#1136) Teach /update-changelog to drop RC-only regression fixes (#1125) Restructure supplemental package dependencies (#1131) (#1133) [codex] Add Shakapacker brand assets (#1135) [codex] Fix shakapacker config helper binstubs (#1132) ...
* origin/main: (26 commits) Adopt agent-workflow binstubs (.agents/bin/ + AGENTS.md pointer) (#1176) Fix Ruby 3.1 CI: exclude broken i18n 1.15.0/1.15.1 (Fiber[]) (#1171) Add AI analysis prompt generator to config exporter (#695) Make Rspack the default bundler for new installs (#1150) Add "Why Shakapacker with Rspack" comparison guide (#1155) Support sass-loader v17 (#1141) [codex] Fix Claude workflow permissions (#1153) Fix README CI badges and add prominent docs link (#1152) Trim README into a docs-site index; relocate content to docs/ and fix deep links (#1148) Tighten helper binstub parity and PATH lookup (#1128) Optimize CI: minimal version matrix on PRs, full matrix on main (#1151) Fix instance-scoped compiler strategies (#1147) Fix Rspack devServer in static watch mode (#1142) Add homepage links for supplemental npm packages (#1145) Release 10.1.0 Update CHANGELOG.md for v10.1.0 (#1139) Expand prerelease-to-stable changelog coalesce guidance in /update-changelog (#1138) Release 10.1.0-rc.2 [codex] Update changelog for v10.1.0-rc.2 (#1136) Teach /update-changelog to drop RC-only regression fixes (#1125) ... # Conflicts: # CHANGELOG.md # lib/install/bin/diff-bundler-config # lib/install/bin/shakapacker-config # lib/tasks/shakapacker/export_bundler_config.rake # package/configExporter/cli.ts # spec/dummy/bin/shakapacker-config
1 participant
Summary
Stamps the v10.1.0 stable release header (was
v10.1.0-rc.2) and curates the prerelease entries per/update-changelogguidance.Curation applied
export_bundler_configdispatch regression that [codex] Fix ESM-safe config helper binstubs #1104 introduced in rc.1 when switching from JS to Ruby binstubs; stable users never see the bug, so the fix is RC-only churn that belongs folded into the original entry. Also folded in [codex] Fix shakapacker config helper binstubs #1132's minor improvements (NODE_ENV from RAILS_ENV mapping, Node lookup without execution, friendlier non-Error CLI messages).../,./, andfile:patterns.[Unreleased]now points fromv10.1.0; replaced[v10.1.0-rc.2]with[v10.1.0]: v10.0.0...v10.1.0.Test plan
yarn lintpassesyarn prettier --check CHANGELOG.mdpassesAfter merge, run
bundle exec rake release(no args) — the rake task picks upv10.1.0from CHANGELOG.md and auto-creates the GitHub release.🤖 Generated with Claude Code
Note
Low Risk
Documentation-only changelog edits with no runtime or dependency behavior changes.
Overview
Promotes the changelog from
v10.1.0-rc.2to stablev10.1.0(May 27, 2026) and rewrites the prerelease notes so they read as one release story instead of RC churn.Consolidations: supplemental npm packages (#1096 + #1133) are merged into a single Added entry describing required peer dependencies (not direct bundled deps); the standalone #1133 Changed bullet is removed. ESM/binstub fixes (#1104 + #1132) and local-path version detection (#1086 + #1106) are each one Fixed entry with both PRs credited. Migration Notes no longer say the supplementals “bundle” the stack as direct dependencies.
Footer links:
[Unreleased]now compares fromv10.1.0;[v10.1.0-rc.2]is replaced by[v10.1.0]: v10.0.0...v10.1.0.Reviewed by Cursor Bugbot for commit 483b154. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit