build: Use generated shaka namespace typedef in tests#10288
Merged
Conversation
Follow-up to shaka-project#9596, which added a generated typedef for the shaka namespace to the externs but left the hand-maintained `shakaNamespaceType` typedef in place in the tests. Generate a standalone externs file containing only the shaka namespace typedef and include it when type-checking the tests, so the tests can refer to the whole library namespace in a type-safe way. Then remove the hand-maintained `shakaNamespaceType` typedef and use the generated `shaka` type instead. - generateExterns.js: add a `--namespace-typedef` flag that writes a standalone externs file with only the namespace typedef (no API re-declarations), so it can be type-checked alongside the uncompiled source without conflicting with the goog.provide declarations. - check.py / compiler.py: generate this file on the fly and include it in the test type-check. - Replace all uses of `shakaNamespaceType` with the generated `shaka` type, renaming a colliding local variable in storage_integration.js and extracting a typed constructor in ui_integration.js. Closes shaka-project#6762 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
Bundle Size Report for PR #10288
|
Collaborator
|
Incremental code coverage: No instrumented code was changed. |
Member
Author
|
@joeyparrish @TAhub can you review it? Thanks! |
TAhub
approved these changes
Jul 1, 2026
avelad
added a commit
that referenced
this pull request
Jul 6, 2026
Follow-up to #9596, which added a generated typedef for the `shaka` namespace to the externs but left the hand-maintained `shakaNamespaceType` typedef in place in the tests. This generates a standalone externs file containing only the `shaka` namespace typedef and includes it when type-checking the tests, so the tests can refer to the whole library namespace in a type-safe way. The hand-maintained `shakaNamespaceType` typedef is then removed in favor of the generated `shaka` type. Closes #6762 Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
avelad
added a commit
that referenced
this pull request
Jul 6, 2026
Follow-up to #9596, which added a generated typedef for the `shaka` namespace to the externs but left the hand-maintained `shakaNamespaceType` typedef in place in the tests. This generates a standalone externs file containing only the `shaka` namespace typedef and includes it when type-checking the tests, so the tests can refer to the whole library namespace in a type-safe way. The hand-maintained `shakaNamespaceType` typedef is then removed in favor of the generated `shaka` type. Closes #6762 Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9596, which added a generated typedef for the
shakanamespace to the externs but left the hand-maintainedshakaNamespaceTypetypedef in place in the tests.This generates a standalone externs file containing only the
shakanamespace typedef and includes it when type-checking the tests, so the tests can refer to the whole library namespace in a type-safe way. The hand-maintainedshakaNamespaceTypetypedef is then removed in favor of the generatedshakatype.Closes #6762