feat(ABR): ABR Manager Min forward buffer (duration) to increase quality abr.minBufferAheadToUpgrade#10280
Open
Iragne wants to merge 7 commits into
Open
feat(ABR): ABR Manager Min forward buffer (duration) to increase quality abr.minBufferAheadToUpgrade#10280Iragne wants to merge 7 commits into
Iragne wants to merge 7 commits into
Conversation
Contributor
Author
|
@avelad sorry i had issue with my account better this PR |
avelad
reviewed
Jun 26, 2026
Contributor
Author
|
I'm still not sure we should do that https://github.com/shaka-project/shaka-player/pull/10280/changes#diff-c620ac9f1f7d7edd591bf600973db0235bcdcd215ae6b226e0597cec35ab88deR564. It can lead to bad switching due to out of date manifest |
Collaborator
|
Bundle Size Report for PR #10280
|
Collaborator
|
Incremental code coverage: 89.13% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to have a parameter in the ABR configuration that will not allow the variant change to an higher quality if the filled buffer is below a threshold.
By default this should be set to 0, more over to some low latency setup.
if the next variant has an equal or higher (>=) bandwidth and the forward buffer is not filled, we just not jump to the next quality. if the buffer is fill with this X duration we can change variant.
If the new variant is lower (<) in term of bandwidth we switch. (this is to protect the going down situation where we are already in bad shape with that current variant)
if no current variant we switch.
if the duration of the current playback till the end of the manifest is smaller to that value we allow the switch. it clearly a bad configuration. (TBD it can be the manifest that has delay and i'm not sure we should do that...)
Close #10263