fix(UI): Align seek bar chapter markers with the playhead thumb#10229
Open
KimKyuHoi wants to merge 1 commit into
Open
fix(UI): Align seek bar chapter markers with the playhead thumb#10229KimKyuHoi wants to merge 1 commit into
KimKyuHoi wants to merge 1 commit into
Conversation
e2aa1ab to
0c7cd3f
Compare
Contributor
Author
|
@efb4f5ff-1298-471a-8973-3d47447115dc Sorry for the delay! Could you possibly check this for me? |
Collaborator
|
Bundle Size Report for PR #10229
|
Collaborator
|
Incremental code coverage: 0.00% |
Member
|
@absidue can you review it? Thanks! |
Member
|
@efb4f5ff-1298-471a-8973-3d47447115dc @absidue any update on your testing? |
Contributor
|
Hi im having major issues on on my side while trying to clone the repo and test it properly. I dont think that i canresolve it anytime soon. Only viable way to test stuff the coming weeks will be through the demo app. Sorry for the inconvenience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related FreeTubeApp/FreeTube#9134
Pass chapters to shaka-player FreeTubeApp/FreeTube#9134 (review)
Fixed chapter markers being misaligned with the playhead thumb — Adjusted markers to use the same thumb correction position calculation as hover thumbnails/tooltips.
Fixed an issue where the chapter was shifted by one position at the boundary point (treated endTime as exclusive so that the boundary time belongs to the chapter starting from there).