Skip to content

fix(UI): Align seek bar chapter markers with the playhead thumb#10229

Open
KimKyuHoi wants to merge 1 commit into
shaka-project:mainfrom
KimKyuHoi:chapter-tooltip
Open

fix(UI): Align seek bar chapter markers with the playhead thumb#10229
KimKyuHoi wants to merge 1 commit into
shaka-project:mainfrom
KimKyuHoi:chapter-tooltip

Conversation

@KimKyuHoi

@KimKyuHoi KimKyuHoi commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Related FreeTubeApp/FreeTube#9134

  • Pass chapters to shaka-player FreeTubeApp/FreeTube#9134 (review)

  • Fixed chapter markers being misaligned with the playhead thumb — Adjusted markers to use the same thumb correction position calculation as hover thumbnails/tooltips.

  • Fixed an issue where the chapter was shifted by one position at the boundary point (treated endTime as exclusive so that the boundary time belongs to the chapter starting from there).

@KimKyuHoi KimKyuHoi marked this pull request as ready for review June 16, 2026 13:50
@KimKyuHoi

Copy link
Copy Markdown
Contributor Author

@efb4f5ff-1298-471a-8973-3d47447115dc Sorry for the delay! Could you possibly check this for me?

@avelad avelad added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround labels Jun 16, 2026
@avelad avelad added this to the v5.2 milestone Jun 16, 2026
@avelad avelad self-requested a review June 16, 2026 13:52
@shaka-bot

shaka-bot commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Bundle Size Report for PR #10229

File HEAD Base Diff
controls.css 37.2 KiB (6.7 KiB) 37.2 KiB (6.7 KiB) 0.0 KiB
controls.modern.css 29.6 KiB (6.1 KiB) 29.6 KiB (6.1 KiB) 0.0 KiB
demo.compiled.debug.js 265.1 KiB (53.7 KiB) 265.1 KiB (53.7 KiB) 0.0 KiB
demo.compiled.js 265.1 KiB (53.7 KiB) 265.1 KiB (53.7 KiB) 0.0 KiB
demo.css 160.2 KiB (25.7 KiB) 160.2 KiB (25.7 KiB) 0.0 KiB
demo.modern.css 144.1 KiB (24.7 KiB) 144.1 KiB (24.7 KiB) 0.0 KiB
locales.js 44.1 KiB (10.9 KiB) 44.1 KiB (10.9 KiB) 0.0 KiB
receiver.compiled.debug.js 150.6 KiB (24.3 KiB) 150.6 KiB (24.3 KiB) 0.0 KiB
receiver.compiled.js 150.6 KiB (24.3 KiB) 150.6 KiB (24.3 KiB) 0.0 KiB
shaka-player.compiled-es2021.debug.js 1288.1 KiB (318.1 KiB) 1288.1 KiB (318.1 KiB) 0.0 KiB
shaka-player.compiled-es2021.js 681.9 KiB (228.3 KiB) 681.9 KiB (228.3 KiB) 0.0 KiB
shaka-player.compiled.debug.js 1568.9 KiB (360.4 KiB) 1568.9 KiB (360.4 KiB) +0.0 KiB
shaka-player.compiled.js 789.6 KiB (257.1 KiB) 789.6 KiB (257.1 KiB) 0.0 KiB
shaka-player.dash-es2021.debug.js 954.5 KiB (240.9 KiB) 954.5 KiB (240.9 KiB) 0.0 KiB
shaka-player.dash-es2021.js 476.0 KiB (163.1 KiB) 476.0 KiB (163.1 KiB) 0.0 KiB
shaka-player.dash.debug.js 1161.3 KiB (272.1 KiB) 1161.2 KiB (272.1 KiB) +0.0 KiB
shaka-player.dash.js 554.0 KiB (184.0 KiB) 554.0 KiB (184.0 KiB) 0.0 KiB
shaka-player.experimental-es2021.debug.js 1682.8 KiB (404.6 KiB) 1682.6 KiB (404.6 KiB) +0.2 KiB
shaka-player.experimental-es2021.js 940.1 KiB (299.5 KiB) 940.0 KiB (299.4 KiB) +0.2 KiB
shaka-player.experimental.debug.js 2029.7 KiB (456.3 KiB) 2029.5 KiB (456.2 KiB) +0.2 KiB
shaka-player.experimental.js 1071.4 KiB (334.1 KiB) 1071.2 KiB (334.1 KiB) +0.2 KiB
shaka-player.hls-es2021.debug.js 985.3 KiB (246.3 KiB) 985.3 KiB (246.3 KiB) 0.0 KiB
shaka-player.hls-es2021.js 509.4 KiB (173.4 KiB) 509.4 KiB (173.4 KiB) 0.0 KiB
shaka-player.hls.debug.js 1197.2 KiB (278.5 KiB) 1197.2 KiB (278.5 KiB) +0.0 KiB
shaka-player.hls.js 590.3 KiB (195.3 KiB) 590.3 KiB (195.3 KiB) 0.0 KiB
shaka-player.transmuxer-worker.debug.js 199.2 KiB (48.3 KiB) 199.2 KiB (48.3 KiB) -0.0 KiB
shaka-player.transmuxer-worker.js 83.8 KiB (27.7 KiB) 83.8 KiB (27.7 KiB) 0.0 KiB
shaka-player.ui-es2021.debug.js 1600.2 KiB (387.1 KiB) 1599.9 KiB (387.1 KiB) +0.2 KiB
shaka-player.ui-es2021.js 899.5 KiB (287.8 KiB) 899.4 KiB (287.7 KiB) +0.2 KiB
shaka-player.ui.debug.js 1917.0 KiB (434.8 KiB) 1916.8 KiB (434.8 KiB) +0.2 KiB
shaka-player.ui.js 1019.2 KiB (319.9 KiB) 1019.1 KiB (319.8 KiB) +0.2 KiB

@shaka-bot

Copy link
Copy Markdown
Collaborator

Incremental code coverage: 0.00%

@avelad

avelad commented Jun 16, 2026

Copy link
Copy Markdown
Member

@absidue can you review it? Thanks!

@avelad

avelad commented Jun 19, 2026

Copy link
Copy Markdown
Member

@efb4f5ff-1298-471a-8973-3d47447115dc @absidue any update on your testing?

@efb4f5ff-1298-471a-8973-3d47447115dc

Copy link
Copy Markdown
Contributor

Hi im having major issues on on my side while trying to clone the repo and test it properly.

I dont think that i canresolve it anytime soon.

Only viable way to test stuff the coming weeks will be through the demo app.

Sorry for the inconvenience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants