Draft
Guard against non-object JSON when switching to table mode in EnvironmentForm#4022
Conversation
Copilot
AI
changed the title
[WIP] Fix code for review comment in PR #4019
Guard against non-object JSON when switching to table mode in EnvironmentForm
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When switching extra-vars to table mode,
JSON.parseoutput was passed directly toObject.keys()without verifying it was a plain object. Scalars,null, and arrays all satisfyObject.keys()— producing rows with numeric/character keys — so saving would silently reshape the stored JSON into an object with a different structure.Changes
web/src/components/EnvironmentForm.vue—extraVarsEditModewatcher,case 'table': added a type guard afterJSON.parsethat falls back to JSON mode if the parsed value is not a plain object:Arrays (
[]), strings ("abc"), numbers, andnullat the root level now keep the editor in JSON mode instead of being silently converted to object-shaped rows on save.