ref: update semaphore version#85
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JohnGuilding
approved these changes
Sep 2, 2025
| @@ -1,7 +1,7 @@ | |||
| NEXT_PUBLIC_DEFAULT_NETWORK=sepolia | |||
| NEXT_PUBLIC_INFURA_API_KEY=abf67af1010b4b8d877e04244f1eac3d | |||
There was a problem hiding this comment.
Unrelated to these changes and non-blocking, but is this a real api key in source control?
Member
Author
There was a problem hiding this comment.
Hey! This is just a test API key running client-side, which is why it starts with NEXT_PUBLIC. It's only for boilerplate/testing purposes, it's free with a limited number of calls. We've never had issues with this before, but if needed, we can set restrictions on the Infura side (e.g., limit it to a specific URL or contract).
NicoSerranoP
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Semaphore version from
4.10.0->4.13.0after the bug fix in the Binary Merkle Root circuit.Reference: semaphore-protocol/semaphore#999
Checklist
yarn formatandyarn lintwithout getting any errors