feat(async-list): port @sanity/sanity-plugin-async-list to the monorepo#968
Draft
stipsan wants to merge 76 commits into
Draft
feat(async-list): port @sanity/sanity-plugin-async-list to the monorepo#968stipsan wants to merge 76 commits into
stipsan wants to merge 76 commits into
Conversation
refactor: replace url+fetchOptions props with loader
* fix: infinite fetch when used as component * fix: settings logic blocked users
* feat: expose client to loader * fix: explicit types
fix(deps): allow studio v4 in peer dep ranges
…generated by scaffold
🦋 Changeset detectedLatest commit: 9b0b345 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…list-2b10 # Conflicts: # pnpm-lock.yaml
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates
@sanity/sanity-plugin-async-listinto the plugins monorepo using thecopy plugingenerator (git subtree import with full history preserved).Demo
Both loader modes verified manually in the test studio (kitchen-sink workspace):
async_list_plugin_demo.mp4
Completed Async List document with both autocomplete fields populated
Changes
git subtreefromsanity-io/sanity-plugin-async-list(history preserved)package.json,package.config.ts,tsconfig.json,tsconfig.build.json,vitest.config.ts) with React Compiler + ESM-only buildAsyncListPluginConfigintosrc/types.tsto break a circular type import betweensrc/index.tsand the component (the dts bundler failed on it)lodashwithlodash-es(lodash-es/debounce.jsdirect import per lint rules), dropped@sanity/incompatible-plugin@sanity/studio-secretsto the in-repoworkspace:*dependency,@sanity/uitocatalog:(v3),@sanity/iconsto^3.7.4void), unused eslint-disable directives, unnecessary default type argument onAutocompletePropsdev/test-studio/src/async-list/index.tsx) with bothseed(PokeAPI) andsearch(Disney API) loader modes, wired into the kitchen-sink workspaceTransfer verification
npm trust github @sanity/sanity-plugin-async-list --file=release.yml --repository=sanity-io/pluginspackage.jsondependencies/peerDependencies/exports verified against original repopnpm dev)pnpm format,pnpm knip,pnpm lint,pnpm build,pnpm test runall passMaintainer follow-up
Agents cannot complete these steps themselves. Please handle them:
npm trust github @sanity/sanity-plugin-async-list --file=release.yml --repository=sanity-io/plugins# [This plugin has moved](https://github.com/sanity-io/plugins/tree/main/plugins/@sanity/sanity-plugin-async-list)async-listBreaking changes (major release)
react-domis now a required peer dependencyTo show artifacts inline, enable in settings.