Skip to content

fix action version input docs#9

Merged
hzrd149 merged 8 commits into
sandwichfarm:mainfrom
hzrd149:fix-incorrect-version-field
Mar 25, 2026
Merged

fix action version input docs#9
hzrd149 merged 8 commits into
sandwichfarm:mainfrom
hzrd149:fix-incorrect-version-field

Conversation

@hzrd149

@hzrd149 hzrd149 commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • update the test workflow to pass the action's version input instead of the stale nsyte_version name
  • refresh the README examples and inputs table to document version, sec, and the deprecated nbunksec alias accurately
  • align the latest-version warning text with current stable nsyte release behavior

@dskvr dskvr self-requested a review March 25, 2026 18:49

@dskvr dskvr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally specifically made it nbunksec to dissuade private key usage. If someone's key gets compromised they will blame me, even if it is illogical. I considered originally having text to encourage ephemeral key usage if a hex key must be used, but then what is the point of it being in CICD?

One of two things

  1. Reconsider this decision
  2. If you must, the README.md will require a NO WARRANTY clause and ample language anywhere secrets are mentioned so that the user very well understands that if their private key is compromised, the loss is not revocable.

@hzrd149 hzrd149 merged commit e60c731 into sandwichfarm:main Mar 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants