add a test that verifies adding an invalid analyzer generates an error. - #53
Merged
Conversation
huffman
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unclear if this test actually adds value.
Logic 2 always supported returning an error when trying to create an analyzer that didn't exist, but previously the error message text was not useful for understanding the root problem.
That is getting fixed, and this originally verified that the correct error text was shown.
However that was removed to avoid depending on the error display text, but since we didn't add a new error type specifically for this error, this test no longer actually verifies the correct error message was displayed.
It might still be helpful to directly test this error case though, since it could be a common error for folks trying to setup custom analyzers in CI environments, since the custom analyzer path does need to be configured correctly.