Report decoder output stride/slice_height via get_output_info - #139
Open
Michal-Szczepaniak wants to merge 1 commit into
Open
Report decoder output stride/slice_height via get_output_info#139Michal-Szczepaniak wants to merge 1 commit into
Michal-Szczepaniak wants to merge 1 commit into
Conversation
For the raw (non-gralloc) decoder data path, gst-droid has to guess the row stride and padded slice height of the output buffer using hardcoded per-colour-format alignment constants, since droid_media_codec_get_output_info never exposed the values the underlying codec actually used. When a device's decoder output doesn't match the guessed alignment, gst-droid reads/writes out of bounds. stagefright already surfaces kKeyStride/kKeySliceHeight in the codec's output format when available; forward them through DroidMediaCodecMetaData so consumers no longer have to guess.
This was referenced Aug 19, 2026
abranson
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the raw (non-gralloc) decoder data path, gst-droid has to guess the row stride and padded slice height of the output buffer using hardcoded per-colour-format alignment constants, since droid_media_codec_get_output_info never exposed the values the underlying codec actually used. When a device's decoder output doesn't match the guessed alignment, gst-droid reads/writes out of bounds.
stagefright already surfaces kKeyStride/kKeySliceHeight in the codec's output format when available; forward them through DroidMediaCodecMetaData so consumers no longer have to guess.
Have in mind the fix has been written by LLM as has been above message. This fixes crash in gst-droid when using qmlglsink.
Corresponding gst-droid fix sailfishos/gst-droid#87