Enable memory sanitizer tests again#435
Merged
Merged
Conversation
Reverts 7ad9e92 and adjusts the test slightly using the current example from https://doc.rust-lang.org/unstable-book/compiler-flags/sanitizer.html#memorysanitizer because the previous `get_unchecked` usage failed with "unsafe precondition(s) violated" instead of actually causing a sanitizer error.
Marcono1234
commented
Jan 20, 2026
|
|
||
| fuzz_target!(|data: &[u8]| { | ||
| if let Some(x) = data.get(0) { | ||
| black_box(x); |
Contributor
Author
There was a problem hiding this comment.
Have replaced the dbg!(x) here with black_box(x).
Is not strictly needed to enable the tests, but I think black_box should achieve the same goal here and might introduce less overhead than dbg!?
Contributor
Author
There was a problem hiding this comment.
Hmm, maybe using black_box is actually a bad idea? See #436
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also #323
It seems the test works on CI again
Reverts 7ad9e92 and adjusts the test slightly using the current example from https://doc.rust-lang.org/unstable-book/compiler-flags/sanitizer.html#memorysanitizer because the previous
get_uncheckedusage failed with "unsafe precondition(s) violated" instead of actually causing a sanitizer error.