Fix CI: ignore W3C heading-level-skip errors and handle failed CSL downloads#1521
Merged
Conversation
Agent-Logs-Url: https://github.com/rstudio/bookdown/sessions/ff2c6eac-3ee3-4f93-a148-c81e20776e1a Co-authored-by: yihui <163582+yihui@users.noreply.github.com>
…CSL file - Add regex pattern to helper-validate_html.R to ignore W3C validator's new heading-level-skip errors; these are expected when testing non-sequential headings and not a bookdown bug - Fix skeleton_get_csl() to detect empty/failed CSL downloads and remove the csl: reference from index.Rmd to prevent pandoc from failing when the Zotero CSL file cannot be downloaded - Bump version to 0.46.3 - Add bookdown.Rcheck/ to .gitignore Agent-Logs-Url: https://github.com/rstudio/bookdown/sessions/ff2c6eac-3ee3-4f93-a148-c81e20776e1a Co-authored-by: yihui <163582+yihui@users.noreply.github.com>
Agent-Logs-Url: https://github.com/rstudio/bookdown/sessions/ff2c6eac-3ee3-4f93-a148-c81e20776e1a Co-authored-by: yihui <163582+yihui@users.noreply.github.com>
…moval Agent-Logs-Url: https://github.com/rstudio/bookdown/sessions/ff2c6eac-3ee3-4f93-a148-c81e20776e1a Co-authored-by: yihui <163582+yihui@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
yihui
April 9, 2026 14:58
View session
|
|
yihui
approved these changes
Apr 9, 2026
…with regex patterns The W3C validator now uses Unicode curly quotes in error messages instead of ASCII double quotes, breaking the setdiff()-based expected_errors matching. Replace expected_errors + setdiff() with regex-based ignore_patterns + grepl() for all known expected errors (CSS IE hacks, custom 'number' attribute on div, and heading level skips). Verified with running Docker validator. Agent-Logs-Url: https://github.com/rstudio/bookdown/sessions/5eb030f0-9464-40f2-934b-6fda34ef3859 Co-authored-by: yihui <163582+yihui@users.noreply.github.com>
yihui
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-rmd.Rfails due to validator using Unicode curly quotes in error messages instead of ASCII double quotes —setdiff()no longer matchesexpected_errorshelper-validate_html.R: replace exact-stringexpected_errors+setdiff()with regexignore_patterns+grepl()for all known expected errorsRd2roxygen::rab('.')W3C_MARKUP_VALIDATOR_BASEURLset (Status: OK)