Skip to content

Offer to install RCurl if we detect this is missing but needed#1515

Merged
yihui merged 2 commits into
mainfrom
rsconnect-rcurl-failsafe
Dec 5, 2025
Merged

Offer to install RCurl if we detect this is missing but needed#1515
yihui merged 2 commits into
mainfrom
rsconnect-rcurl-failsafe

Conversation

@cderv

@cderv cderv commented Dec 2, 2025

Copy link
Copy Markdown
Collaborator

due to

This is only needed if no rsconnect release before a bookdown release.

Without this, the users will face the error shown in rstudio/rsconnect#1265

@cderv

cderv commented Dec 4, 2025

Copy link
Copy Markdown
Collaborator Author

We don't need this if rsconnect goes to CRAN before us

@yihui yihui marked this pull request as ready for review December 5, 2025 02:45

@yihui yihui left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems rsconnect 1.7.0 is unlikely to make its way to CRAN tonight, so I'm merging this PR and will prepare the bookdown release later.

@yihui yihui merged commit 1cb10c0 into main Dec 5, 2025
15 checks passed
@yihui yihui deleted the rsconnect-rcurl-failsafe branch December 5, 2025 02:47
cderv added a commit that referenced this pull request Dec 8, 2025
yihui pushed a commit that referenced this pull request Dec 8, 2025
* Revert "Offer to install RCurl if we detect this is missing but needed (#1515)"

This reverts commit 1cb10c0.
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants