Skip to content

Update inkino_app_bar.dart #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samirpokharel wants to merge 1 commit into
base: development
Choose a base branch
from
+10 −11
Open

Update inkino_app_bar.dart #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions mobile/lib/ui/inkino_app_bar.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ class _InkinoAppBarState extends State<InkinoAppBar>
@override
void dispose() {
super.dispose();
_searchQuery.close()

@Vasco-90 Vasco-90 Oct 26, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing semicolon. _searchQuery should above super call.

}

void _toggleTheaters() async {
Expand Down Expand Up @@ -57,19 +58,21 @@ class _InkinoAppBarState extends State<InkinoAppBar>
if (_searchQuery == null || _searchQuery.text.isEmpty) {
// Stop searching.
Navigator.pop(context);
return;
return null;

@Vasco-90 Vasco-90 Oct 26, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor - returning null isn't needed.

}else{
_clearSearchQuery();
return null;
}

_clearSearchQuery();
},
},
),
];
}

return [
_TheaterIconButton(_theatersOpen, _toggleTheaters),
IconButton(
color: Colors.white70,
color: Colors.white60,
icon: const Icon(Icons.search),
onPressed: _startSearch,
),
Expand All @@ -81,7 +84,7 @@ class _InkinoAppBarState extends State<InkinoAppBar>
controller: _searchQuery,
autofocus: true,
decoration: const InputDecoration(
hintText: 'Search movies & showtimes...',
hintText: 'Search you want to see..',
border: InputBorder.none,
hintStyle: const TextStyle(color: Colors.white30),
),
Expand All @@ -98,17 +101,13 @@ class _InkinoAppBarState extends State<InkinoAppBar>
void _startSearch() {
ModalRoute.of(context).addLocalHistoryEntry(_searchEntry);

setState(() {
_isSearching = true;
});
setState(() => _isSearching = true);
}

void _stopSearching() {
_clearSearchQuery();

setState(() {
_isSearching = false;
});
setState(() =>_isSearching = false);
}

void _clearSearchQuery() {
Expand Down