Skip to content

fix(joint-trajectory-controller): use active tolerances in update step - #2101

Merged
christophfroehlich merged 3 commits into
ros-controls:masterfrom
domire8:fix/tolerances
Jul 30, 2026
Merged

fix(joint-trajectory-controller): use active tolerances in update step#2101
christophfroehlich merged 3 commits into
ros-controls:masterfrom
domire8:fix/tolerances

Conversation

@domire8

@domire8 domire8 commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

This PR fixes issue #2100

@codecov

codecov Bot commented Jan 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.83%. Comparing base (cbe0645) to head (cebfa0e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2101      +/-   ##
==========================================
- Coverage   86.85%   86.83%   -0.02%     
==========================================
  Files         148      148              
  Lines       16267    16267              
  Branches     1365     1365              
==========================================
- Hits        14128    14126       -2     
- Misses       1632     1635       +3     
+ Partials      507      506       -1     
Flag Coverage Δ
unittests 86.83% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ory_controller/src/joint_trajectory_controller.cpp 85.23% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions Bot added the stale label Feb 23, 2026
@domire8

domire8 commented Feb 23, 2026

Copy link
Copy Markdown
Contributor Author

I believe this would still be valid @christophfroehlich ?

@github-actions github-actions Bot removed the stale label Feb 24, 2026

@MarqRazz MarqRazz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when a goal includes tolerances and then a follow up one does not? Will it fall back to the default_tolerances_ when they are not specified?

@domire8

domire8 commented Feb 25, 2026

Copy link
Copy Markdown
Contributor Author

What happens when a goal includes tolerances and then a follow up one does not? Will it fall back to the default_tolerances_ when they are not specified?

The way I understand this part, yes.

@github-actions

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions Bot added the stale label Apr 13, 2026
@domire8

domire8 commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

This PR is not stale

@github-actions github-actions Bot removed the stale label Apr 14, 2026
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions Bot added the stale label Jun 1, 2026

@christophfroehlich christophfroehlich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@christophfroehlich christophfroehlich added backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. backport-humble Triggers PR backport to ROS 2 humble. labels Jul 30, 2026
@christophfroehlich
christophfroehlich merged commit c746c8e into ros-controls:master Jul 30, 2026
26 of 28 checks passed
@github-project-automation github-project-automation Bot moved this from Needs review to Done in Review triage Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-humble Triggers PR backport to ROS 2 humble. backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. stale

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Joint Trajectory Controller tolerances

3 participants