fix(joint-trajectory-controller): use active tolerances in update step - #2101
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2101 +/- ##
==========================================
- Coverage 86.85% 86.83% -0.02%
==========================================
Files 148 148
Lines 16267 16267
Branches 1365 1365
==========================================
- Hits 14128 14126 -2
- Misses 1632 1635 +3
+ Partials 507 506 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
|
I believe this would still be valid @christophfroehlich ? |
MarqRazz
left a comment
There was a problem hiding this comment.
What happens when a goal includes tolerances and then a follow up one does not? Will it fall back to the default_tolerances_ when they are not specified?
The way I understand this part, yes. |
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
|
This PR is not stale |
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
c746c8e
into
ros-controls:master
This PR fixes issue #2100