Skip to content

Provide force-torque sensor data through gz_system to controller_manager - fixes to original PR for Humble - #637

Merged
ahcorde merged 14 commits into
ros-controls:humblefrom
KNR-PW:humble
Aug 18, 2025
Merged

Provide force-torque sensor data through gz_system to controller_manager - fixes to original PR for Humble#637
ahcorde merged 14 commits into
ros-controls:humblefrom
KNR-PW:humble

Conversation

@BartlomiejK2

@BartlomiejK2 BartlomiejK2 commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

Added Force-Torque sensor for Humble, related to #635 and #625.

@BartlomiejK2
BartlomiejK2 requested a review from ahcorde as a code owner July 17, 2025 12:11
@BartlomiejK2

Copy link
Copy Markdown
Contributor Author

Tests are failing due to lack of force_torque_sensor/ForceTorqueSensor in test environment.

@christophfroehlich

Copy link
Copy Markdown
Member

Tests are failing due to lack of force_torque_sensor/ForceTorqueSensor in test environment.

can't you install or build it?

@BartlomiejK2

Copy link
Copy Markdown
Contributor Author

@christophfroehlich

can't you install or build it?

I can build and test packages locally and it works fine, but gz_ros2_control CI has problems with tests, it does not have force_torque_sensor/ForceTorqueSensor.

@christophfroehlich

Copy link
Copy Markdown
Member

The CI job is defined here, you can add what is necessary there.

Comment thread .github/workflows/ci-humble.yaml Outdated

@christophfroehlich christophfroehlich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@christophfroehlich christophfroehlich linked an issue Jul 22, 2025 that may be closed by this pull request
Comment thread doc/index.rst Outdated
Comment thread doc/index.rst
Comment on lines +179 to 182
It is important to add this as ``reference`` sensor in the ``<gazebo>`` tag in your URDF file.


Add the gz_ros2_control plugin
==========================================

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It is important to add this as ``reference`` sensor in the ``<gazebo>`` tag in your URDF file.
Add the gz_ros2_control plugin
==========================================
It is important to add this as ``reference`` sensor in the ``<gazebo>`` tag in your URDF file.
Add the gz_ros2_control plugin
==============================

Comment thread gz_ros2_control/src/gz_system.cpp
Comment thread gz_ros2_control_demos/launch/cart_example_ft_sensor.launch.py Outdated
Comment thread gz_ros2_control_demos/launch/cart_example_ft_sensor.launch.py Outdated
Comment thread gz_ros2_control_demos/launch/cart_example_ft_sensor.launch.py Outdated
Comment thread gz_ros2_control_tests/tests/ft_sensor_test.py

@ahcorde ahcorde left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some conflicts too

@christophfroehlich

Copy link
Copy Markdown
Member

Please don't force push in already reviewed PRs, it makes it hard to track the conversations and do a fast re-review.

@BartlomiejK2
BartlomiejK2 requested a review from ahcorde August 1, 2025 17:40
@ahcorde
ahcorde merged commit bda36fb into ros-controls:humble Aug 18, 2025
9 checks passed
@christophfroehlich christophfroehlich mentioned this pull request Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FTs to Humble

4 participants