[reve] Fix misleading client error message in streaming of an empty projected track#22637
Open
alja wants to merge 1 commit into
Open
[reve] Fix misleading client error message in streaming of an empty projected track#22637alja wants to merge 1 commit into
alja wants to merge 1 commit into
Conversation
Contributor
Author
|
@linev Please check. |
linev
approved these changes
Jun 17, 2026
Test Results 21 files 21 suites 3d 14h 55m 20s ⏱️ For more details on these failures, see this check. Results for commit 0839e3a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client logs reported an error in streaming binary data from the server to the client.
The erroneous message was generated because REveTrackProjected::WriteCoreJson created a render_data JSON object even when the track had no points. This can be reproduced by creating a track with a vertex outside the track propagator radius and then projecting it.
The missing check for an empty track in REveTrackProjected::WriteCoreJson had no consequence on streaming and rendering of other elements in the scene.