Skip to content

[reve] Fix misleading client error message in streaming of an empty projected track#22637

Open
alja wants to merge 1 commit into
root-project:masterfrom
alja:mismatch_err
Open

[reve] Fix misleading client error message in streaming of an empty projected track#22637
alja wants to merge 1 commit into
root-project:masterfrom
alja:mismatch_err

Conversation

@alja

@alja alja commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

The client logs reported an error in streaming binary data from the server to the client.
The erroneous message was generated because REveTrackProjected::WriteCoreJson created a render_data JSON object even when the track had no points. This can be reproduced by creating a track with a vertex outside the track propagator radius and then projecting it.

The missing check for an empty track in REveTrackProjected::WriteCoreJson had no consequence on streaming and rendering of other elements in the scene.

@alja alja requested a review from linev as a code owner June 16, 2026 20:16
@alja

alja commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

@linev Please check.

@linev linev self-assigned this Jun 17, 2026
@github-actions

Copy link
Copy Markdown

Test Results

    21 files      21 suites   3d 14h 55m 20s ⏱️
 3 868 tests  3 818 ✅   0 💤 50 ❌
73 317 runs  73 061 ✅ 205 💤 51 ❌

For more details on these failures, see this check.

Results for commit 0839e3a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants