[cppyy] Auto-downcast objects returned through smart pointers#22586
Open
guitargeek wants to merge 2 commits into
Open
[cppyy] Auto-downcast objects returned through smart pointers#22586guitargeek wants to merge 2 commits into
guitargeek wants to merge 2 commits into
Conversation
Test Results 22 files 22 suites 3d 19h 16m 5s ⏱️ For more details on these failures, see this check. Results for commit aac5660. ♻️ This comment has been updated with latest results. |
Returning an object by raw pointer already triggers an automatic downcast to its actual (most derived) class, but returning it through a smart pointer (`std::unique_ptr`, `std::shared_ptr`) did not: the object was bound as the declared underlying type, so derived-class members were not accessible. This became more and more of a nuisance as smart pointers become more common in C++ interface. Therefore, this commit implements automatic downcasting also for returned smart pointers. Closes root-project#16210.
Now that also objects returned by smart pointer get automatically downcasted to the actual type, we don't need to dereference returned smart pointer objects to trigger the automatic downcasting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning an object by raw pointer already triggers an automatic downcast to its actual (most derived) class, but returning it through a smart pointer (
std::unique_ptr,std::shared_ptr) did not: the object was bound as the declared underlying type, so derived-class members were not accessible.This became more and more of a nuisance as smart pointers become more common in C++ interface.
Therefore, this commit implements automatic downcasting also for returned smart pointers.
Closes #16210.