Draw winrate and score lead in the graph.#79
Conversation
|
I doubt I'll accept this honestly, I'm trying to avoid info overload. If you were going to do it at all, I think you can just call But I doubt I'll merge it. |
|
Also best not to draw it if the program is in a special mode (autoanalysis etc) because it will flicker in and out of existence. So I'd do it like so: let analysis_str = "";
if (!hub.__autoanalysis && !hub.__backanalysis && !hub.__autoplay && !hub.__play_colour) {
if (config.graph_type === 1) {
let val = node.stored_winrate();
if (typeof val === "number") {
analysis_str = `(${(val * 100).toFixed(1)}%) `;
}
} else if (config.graph_type === 2) {
let val = node.stored_score();
if (typeof val === "number") {
let s = val.toFixed(1);
if (!s.startsWith("-")) {
s = "+" + s;
}
analysis_str = "(" + s + ") ";
}
}
} |
|
Already fixed the flicker issue. Does it look better? |
|
I guess so. But as I say, it's not a feature I really want, sorry. |
|
I suggest to add axis to the curve and highlight the max and min values. If there is only a curve as is, it would be hard to know which move is important in a Go game... |
|
I would accept & enable this feature. The graph is very strange in that the meaning is implicit - there is no axis, no ticks, not even anything saying whether left or right represents white/black. You just have to memorize that fact, and it's inefficient. |
There is the analysis winrate or score lead value on the graph. I think that it is more easy to get the best winrate if there are too many candidate moves? The value is always black's POV.
Draw winrate if we set 'Display -> Graph -> Winrate'.

Draw score lead if we 'Display -> Graph -> Score'.
