Prepare for 2025.11.0 release - #1059
Conversation
Summary of ChangesHello @Nicogene, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request prepares the project for an upcoming release by performing essential versioning updates. It involves incrementing the project's internal version number and adjusting the minimum required version for a key dependency, ensuring compatibility and reflecting the project's ongoing development. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request prepares for a new release by updating version numbers. The project version in CMakeLists.txt is bumped to 2.11.0 and the minimum required version for icub_firmware_shared is updated. My review identifies an inconsistency between the version number in the code and the one mentioned in the pull request title. This should be resolved to avoid confusion about the release version.
| set(ROOT_PROJECT_NAME ICUB) | ||
| project(${ROOT_PROJECT_NAME} LANGUAGES C CXX | ||
| VERSION 2.10.0) | ||
| VERSION 2.11.0) |
There was a problem hiding this comment.
The version is being updated to 2.11.0, while the pull request title indicates a release for 2025.11.0. This discrepancy can lead to confusion for maintainers and users about the correct release version. To ensure clarity, please align the version in the code with the one intended for the release, and update the PR title if necessary.
No description provided.