[Openjdk-2969] runtime images and JAVA_ARGS, JAVA_OPTIONS handling (ubi8)#492
Closed
jmtd wants to merge 5 commits into
Closed
[Openjdk-2969] runtime images and JAVA_ARGS, JAVA_OPTIONS handling (ubi8)#492jmtd wants to merge 5 commits into
jmtd wants to merge 5 commits into
Conversation
Passes for current builders, fails for current runtimes. https://issues.redhat.com/browse/OPENJDK-2968 Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
Move the feature file with the JAVA_OPTIONS test into a module which is included by the runtime images (run) and retag it so it is applied to the runtime images. Improve the test's log check. Test passes for builder images and fails for runtime images. https://issues.redhat.com/browse/OPENJDK-2968 Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
https://issues.redhat.com/browse/OPENJDK-2968 Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
This was used in the RHEL7 images but not since. Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
jmtd
changed the title
Move the handling of JAVA_OPTIONS, JAVA_OPTS and suffixing of JAVA_ARGS onto the command line, as well as dispatching to an application-supplied run script, from s2i/run to run-java.sh. This is to make this logic available to the runtime images. <https://issues.redhat.com/browse/OPENJDK-2968> Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
jmtd
force-pushed
the
OPENJDK-2968-JAVA_ARGS_runtime
branch
from
5d17ddd to
b08c9fc
Compare
Member
Author
|
I don't think we'll ever land this in ubi8. See #589 for the ubi9 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the run logic is implemented in bin/s2i which means it is not applied in the runtime images.
https://issues.redhat.com/browse/OPENJDK-2969