Skip to content

Add schema evolution rules for vector<Float_t> to vector<Double_t> change #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmargalejo wants to merge 3 commits into
base: master
Choose a base branch
from
+14 −0
Open

Add schema evolution rules for vector<Float_t> to vector<Double_t> change #129

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
926790d
Add schema evolution rules for vector<Float_t> to vector<Double_t> ch…
cmargalejo Jun 11, 2026
afefb80
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 12, 2026
674a904
Trigger CI: pick up restG4 validation reference fix
cmargalejo Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions inc/TRestDetectorSignal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,4 +166,18 @@ class TRestDetectorSignal {

ClassDef(TRestDetectorSignal, 4);
};

// Schema evolution: fSignalTime and fSignalCharge changed from vector<Float_t> to
// vector<Double_t> in ClassDef v4 (PR#109, March 2024). Files written with ClassDef
// version <= 3 store the float layout; these rules tell ROOT how to convert on read.
// Note: the rules can only fire when the input file contains the StreamerInfo of the
// on-disk version of this class. See rest-for-physics/detectorlib#125.
#pragma read sourceClass = "TRestDetectorSignal" version = "[-3]" source = \
"std::vector<Float_t> fSignalTime" targetClass = "TRestDetectorSignal" target = "fSignalTime" code = \
"{ fSignalTime.assign(onfile.fSignalTime.begin(), onfile.fSignalTime.end()); }"

#pragma read sourceClass = "TRestDetectorSignal" version = "[-3]" source = \
"std::vector<Float_t> fSignalCharge" targetClass = "TRestDetectorSignal" target = "fSignalCharge" code = \
"{ fSignalCharge.assign(onfile.fSignalCharge.begin(), onfile.fSignalCharge.end()); }"

#endif
Loading