Refactor short circuiting identifiers - #1439
Merged
Merged
Conversation
Collaborator
Author
|
Additional points:
|
Test Results 15 files 33 suites 0s ⏱️ Results for commit fad4f72. ♻️ This comment has been updated with latest results. |
Alasdair
force-pushed
the
and_or_bool
branch
from
September 8, 2025 20:07
3ca88b9 to
fad4f72
Compare
jn80842
pushed a commit
to GaloisInc/sail
that referenced
this pull request
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The short-circuiting operators are quite special, but previously they were just identifiers with special names
Id "and_bool". Now they have their own constructors in theid_auxtype (And_bool/Or_bool), so they can easily be identified in the semantics without any kind of string comparison.Probably they should have been expressions like
E_short_circuit, but that would be a much bigger refactor. Might be worth doing though.This is the first step in a simplification of identifier handling. Currently the operator
++could beId "++"orOperator "++"depending on where it is. Plan is to removeE_app_infixand just useE_appwith an attribute indicating if it was desugared from an infix form. Then havingOperator xalways for operators andId xfor C-style identifiers.