Create OLM v1 chart - #657
Conversation
|
@itewk ; you OK to review? |
|
@garethahealy i'm trying to figure out why your new test didn't run as a github action? any idea? |
There was a problem hiding this comment.
@garethahealy can you move this to a ci folder rather then _test. then the automatic github action testing will pick this up.
There was a problem hiding this comment.
you want @marpears - as he was the PR raiser :)
There was a problem hiding this comment.
whoooops. sorry. missread that.
|
Hi @itewk thanks for the review and sorry for the delay in getting back to you! I have made the modification as requested |
|
@marpears thanks for the update, looks like you have some test failures to clean up :) |
|
Hi @itewk I've added the chart to the helm ct exclusion list since it requires OLM v1 CRDs that won't exist in the kind cluster. Also I've pointed confbatstest to v4.6 as it was failing for all charts due to Rego mismatch Fingers crossed! |
|
@marpears would it be a huge lift to add a step to the test to install the OLV v1 CRs like we do for the previous version testing? |
|
Hi @itewk I've added a step to the kind cluster setup which installs OLM v1 CRs so that the unit tests for the olmv1 chart run |
|
@marpears can you merge all the minit commits down to one or two please? otherwise LGTM and will merge |
|
@marpears thanks for all the work! |
3 participants
What is this PR About?
OLM v1 is a declarative and GitOps friendly way of installing operators or extensions, and has been GA since OpenShift 4.18.
In this PR, a new helm chart named olmv1 has been created which configures ClusterExtension CRs and the supporting manifests needed to provide the necessary rbac for installation to complete.
Having a chart for OLM v1 will hopefully help boost the testing and adoption effort needed to ensure compatibility of all operators.
How do we test this?
The chart can be linted using this command:
helm lint -f charts/olmv1/_test/values.yaml charts/olmv1The conftest script used by the GitHub action has been updated to include this new chart and uses the test values file.
cc: @redhat-cop/day-in-the-life