Output keywriter log, provisioning log and die messages to stderr#122
Open
oliora wants to merge 1 commit into
Open
Output keywriter log, provisioning log and die messages to stderr#122oliora wants to merge 1 commit into
oliora wants to merge 1 commit into
Conversation
oliora
force-pushed
the
improve-logging
branch
2 times, most recently
from
February 13, 2025 13:48
684b74d to
a68ea53
Compare
oliora
force-pushed
the
improve-logging
branch
from
February 13, 2025 13:49
a68ea53 to
343af47
Compare
Collaborator
|
Thanks for the submission @oliora Having considered the change and implications, I am not inclined to accept this PR as-is:
|
Author
|
@tdewey-rpi fair enough but still would be useful if all logging is duplicated to a single place unless it's something that is not trivial to implement. Even if Please also remember that it's not possible to provision RPi5 automatically since it does not have a jumper for OTG boot so provisioning needs to be assisted with rebooting the device in OTG mode when needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our workflow we run
rpi-sb-provisioner.shmanually and if anything went wrong it's inconvenient to gather logs from multiple places.For
diefunction it looks more logical to also output the die reason to stderr rather than to debug "channel".