feat: create maintenance incident type via API - #510
Open
borisjacquot wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I wanted to create a Maintenance via the API but it is currently not possible.
Summary
This PR allows to give 2 more parameters in the API:
incident_typeend_date_timeIt also adds a new check inside
CreateIncident()in order to avoid dirty values in the DB.API calls
Create a Maintenance
Create an incident with a wrong type
Notes
I noticed that creating a maintenance in this way, the state was set to "INVESTIGATING" instead of "RESOLVED" (when creating via web UI). It looks impactless but I'm not aware of the whole workflows.
Fixes #468