docs: fix incorrect example in ?vec_duplicate#2169
Closed
LeonidasZhak wants to merge 1 commit into
Closed
Conversation
The example for equivalence with `duplicated()` used `==` instead of `!=`. `vec_duplicate_id(x) == seq_along(x)` returns TRUE for first occurrences, while `duplicated(x)` returns TRUE for duplicates (not first occurrences). Fixes r-lib#1822.
Member
|
Assuming this is the same as tidymodels/broom#1281 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs: fix incorrect example in ?vec_duplicate
The example for equivalence with
duplicated()used==instead of!=.vec_duplicate_id(x) == seq_along(x)returns TRUE for first occurrences,while
duplicated(x)returns TRUE for duplicates (not first occurrences).Fixes #1822.
Summary
Fix the example in
?vec_duplicatethat claims to show equivalence withduplicated().The example used
vec_duplicate_id(x) == seq_along(x)but this returnsTRUEfor first occurrences (i.e., non-duplicates), whileduplicated(x)returnsTRUEfor duplicates. The correct comparison is!=.Changes
R/dictionary.R: Change==to!=in the example commentman/vec_duplicate.Rd: Regenerated from roxygenVerification
Fixes #1822.