Skip to content

fix: remove audio pause during zero-delay verse transitions #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mubashir78 wants to merge 1 commit into
base: production
Choose a base branch
from
Open

fix: remove audio pause during zero-delay verse transitions #3318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 30 additions & 12 deletions src/xstate/actors/audioPlayer/audioPlayerMachine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,18 +327,33 @@ export const audioPlayerMachine =
'User either clicks on the pause button or presses the space key',
target: '#audioPlayer.VISIBLE.AUDIO_PLAYER_INITIATED.PAUSED.ACTIVE',
},
REPEAT_AYAH: {
actions: [
assign({
ayahNumber: (context, event: any) => event.ayahNumber,
verseDelay: (context, event: any) => event.verseDelay,
}),
'pauseAudio',
'setAudioPlayerCurrentTime',
],
description: 'Repeat the current ayah',
target: '#audioPlayer.VISIBLE.AUDIO_PLAYER_INITIATED.DELAYING',
},
REPEAT_AYAH: [
{
actions: [
assign({
ayahNumber: (context, event: any) => event.ayahNumber,
verseDelay: (context, event: any) => event.verseDelay,
}),
'pauseAudio',
'setAudioPlayerCurrentTime',
],
cond: 'hasVerseDelay',
description:
'Repeat the current ayah with a configurable delay between verses',
target: '#audioPlayer.VISIBLE.AUDIO_PLAYER_INITIATED.DELAYING',
},
{
actions: [
assign({
ayahNumber: (context, event: any) => event.ayahNumber,
}),
'setAudioPlayerCurrentTime',
],
description:
'Repeat the current ayah seamlessly without pausing the audio',
target: '#audioPlayer.VISIBLE.AUDIO_PLAYER_INITIATED.PLAYING.ACTIVE',
},
],
SEEKING: {
description:
'When the mouse or keyboard keys are clicked to jump forward/backward 5 or 10 seconds or when the user wants to navigate to a specific time.',
Expand Down Expand Up @@ -1075,6 +1090,9 @@ export const audioPlayerMachine =
return context.surah === event.surah && reciterId === context.audioData?.reciterId;
},
isRepeatActive: (context) => !!context.repeatActor,
hasVerseDelay: (context, event: any) => {
return event.verseDelay > 0;
},
isUsingCustomReciterId: (context, event) => !!event.reciterId,
isAudioAlmostEnded: (context) => {
const { currentTime } = context.audioPlayer;
Expand Down