fix: fall back to Redux lastReadVerse for Continue Reading surah (#3210) - #3311
Open
Mubashir78 wants to merge 2 commits into
Open
fix: fall back to Redux lastReadVerse for Continue Reading surah (#3210)#3311Mubashir78 wants to merge 2 commits into
Mubashir78 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d40aa5a9a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…e in session gating
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3210
Summary
When a logged-in user navigates to a Surah and then returns to the dashboard, the "Continue Reading" card sometimes shows the wrong Surah (the previously read one instead of the current one).
Root Cause
The dashboard reading section uses a priority chain to resolve the surah shown:
useSWRImmutable)The server-side reading sessions are updated by a debounced API call (
addReadingSession) triggered by the intersection observer, which fires only when the user scrolls. Additionally,useSWRImmutabledoes not re-fetch after the cache is invalidated, so the dashboard may serve stale session data.The Redux
lastReadVerse(viauseSyncChapterPage) is updated immediately on every navigation but was not included in the priority chain.Fix
Added
lastReadVerse.chapterIdand the corresponding verse number as a fallback in the priority chain, between the server-side reading sessions and the hardcoded default of Surah 1. This ensures the locally-tracked last read verse is used when the server data is stale or unavailable.Testing
effectiveAyahVerseKey→firstVerseOfStoredPage→recentlyReadVerseKeys→lastReadVerse→ default 1.