feat: implement playing ta'awwudh and basmalah for Surah and Ayah playback - #3281
feat: implement playing ta'awwudh and basmalah for Surah and Ayah playback#3281chabandou wants to merge 1 commit into
Conversation
…y for Surah and Ayah playback
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d15e200d2d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| onError: '#audioPlayer.VISIBLE.LOADING_CUSTOM_RECITER_DATA', | ||
| }, | ||
| on: { | ||
| END: '#audioPlayer.VISIBLE.LOADING_CUSTOM_RECITER_DATA', |
There was a problem hiding this comment.
Preserve reciter payload before entering custom loading state
This transition now enters LOADING_CUSTOM_RECITER_DATA from an END event emitted after intro playback, but fetchCustomReciter reads event.surah and event.reciterId. END (and PAUSE) do not carry those fields, so custom-reciter flows lose the selected reciter/chapter context and can issue invalid fetches (e.g. reciter/chapter becoming undefined) after intro audio completes. Please persist the needed custom-reciter parameters in context before intro playback (or transition with an event that still includes them) before invoking fetchCustomReciter.
Useful? React with 👍 / 👎.
Summary
Saying Taʿawwudh (أعوذ بالله من الشيطان الرجيم) is Obligatory (wājib) according to many Muslim scholars
This is based directly on the Qur’an:
“So when you recite the Qur’an, seek refuge in Allah from Shayṭān, the expelled.”
— Surah An-Nahl (16:98)
This PR implements a feature where the Taʿawwudh and Basmalah are played before the recitation of a full Surah starts and Taʿawwudh only when a recitation of a single Ayah starts. May Allah accept this humble contribution.
Closes: QF-XXXX
Type of Change
Rollback Safety
Test Plan
Testing steps:
Edge Cases Verified
Pre-Review Checklist
Code Quality
anytypes used (or justified if unavoidable)Testing & Validation
yarn test)yarn lint)yarn build)Documentation
AI Assistance Disclosure