Skip to content

fix: add missing @/styles alias to Storybook webpack config #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mir-Zairan wants to merge 1 commit into
base: production
Choose a base branch
from
Open

fix: add missing @/styles alias to Storybook webpack config #3272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 22 additions & 26 deletions .storybook/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
const path = require("path");
const path = require('path');

module.exports = {
stories: ["../src/**/*.stories.tsx"],
stories: ['../src/**/*.stories.tsx'],
addons: [
"@storybook/addon-links",
"@storybook/addon-essentials",
"@storybook/addon-a11y",
"@storybook/addon-storysource",
"storybook-addon-rtl"
'@storybook/addon-links',
'@storybook/addon-essentials',
'@storybook/addon-a11y',
'@storybook/addon-storysource',
'storybook-addon-rtl',
],
framework: {
name: '@storybook/nextjs',
Expand All @@ -19,44 +19,40 @@ module.exports = {
checkOptions: {},
// ideally we use `react-docgen-typescript`. But there's still some issue, related to webpack 5.
// so we use `react-docgen` for now
reactDocgen: "react-docgen",
reactDocgen: 'react-docgen',
// reactDocgenTypescriptOptions: {
// shouldExtractLiteralValuesFromEnum: true,
// propFilter: (prop) => (prop.parent ? !/node_modules/.test(prop.parent.fileName) : true),
// },
},
webpackFinal: async (config) => {
// Add support for absolute paths
config.resolve.modules = [
...(config.resolve.modules || []),
path.resolve("./"),
];
config.resolve.modules = [...(config.resolve.modules || []), path.resolve('./')];

// @/ root alias doesn't work in storybook, so we have to write the aliases manually
const otherAliases = ["components", "utils", "redux", "hooks", "contexts"];
const otherAliases = ['components', 'utils', 'redux', 'hooks', 'contexts'];

// Add support for module aliases (same aliases in tsconfig.json)
config.resolve.alias = {
...(config.resolve.alias || {}),
"@/icons": path.resolve(__dirname, "../public/icons"),
"@/public": path.resolve(__dirname, "../public"),
"@/dls": path.resolve(__dirname, "../src/components/dls"),
"@/api": path.resolve(__dirname, "../src/api"),
"@/data": path.resolve(__dirname, "../data"),
"@/types": path.resolve(__dirname, "../types"),
'@/icons': path.resolve(__dirname, '../public/icons'),
'@/public': path.resolve(__dirname, '../public'),
'@/styles': path.resolve(__dirname, '../src/styles'),
'@/dls': path.resolve(__dirname, '../src/components/dls'),
'@/api': path.resolve(__dirname, '../src/api'),
'@/data': path.resolve(__dirname, '../data'),
'@/types': path.resolve(__dirname, '../types'),
...otherAliases.reduce(
(acc, folder) => ({
...acc,
[`@/${folder}`]: path.resolve(__dirname, "../src", folder),
[`@/${folder}`]: path.resolve(__dirname, '../src', folder),
}),
{}
{},
),
};

const fileLoaderRule = config.module.rules.find((rule) =>
Array.isArray(rule.test)
? rule.test[0]?.test(".svg")
: rule.test?.test(".svg")
Array.isArray(rule.test) ? rule.test[0]?.test('.svg') : rule.test?.test('.svg'),
);
fileLoaderRule.exclude = /\.svg$/;
// This is needed for inline svg imports
Expand All @@ -65,14 +61,14 @@ module.exports = {
exclude: /node_modules/,
use: [
{
loader: "@svgr/webpack",
loader: '@svgr/webpack',
options: {
prettier: false,
svgo: true,
svgoConfig: {
plugins: [
{
name: "preset-default",
name: 'preset-default',
params: {
overrides: {
removeViewBox: false,
Expand Down