Skip to content
This repository was archived by the owner on Oct 1, 2020. It is now read-only.

fixing vulnerability: XXE#679

Open
marcosptf wants to merge 8 commits into
quokkaproject:masterfrom
marcosptf:hotfix/issue676
Open

fixing vulnerability: XXE#679
marcosptf wants to merge 8 commits into
quokkaproject:masterfrom
marcosptf:hotfix/issue676

Conversation

@marcosptf

@marcosptf marcosptf commented May 19, 2019

Copy link
Copy Markdown
Collaborator

fixed error reported on issue #676

was added a new function to remove tags in strings and pytest to this new function;

Att,
@marcosptf

@pep8speaks

pep8speaks commented May 19, 2019

Copy link
Copy Markdown

Hello @marcosptf! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 11:1: W391 blank line at end of file

Line 14:1: E265 block comment should start with '# '
Line 23:80: E501 line too long (80 > 79 characters)
Line 30:1: E265 block comment should start with '# '
Line 36:1: E302 expected 2 blank lines, found 1
Line 47:1: E302 expected 2 blank lines, found 1
Line 48:46: W291 trailing whitespace
Line 50:1: E302 expected 2 blank lines, found 1
Line 55:1: E302 expected 2 blank lines, found 1
Line 60:1: E302 expected 2 blank lines, found 1
Line 61:80: E501 line too long (102 > 79 characters)
Line 62:80: E501 line too long (114 > 79 characters)
Line 64:80: E501 line too long (132 > 79 characters)
Line 65:1: W391 blank line at end of file

Comment last updated at 2019-07-19 10:06:20 UTC

# 'og_image': 'foo',
# 'series': 'aa',
# 'asides': 'aaa'
# 'cover': 'foo',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it will not be used in the future, consider removing these comments

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in another pr => #680

@brenorr brenorr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved,

Just look the comment before merge.

@marcosptf marcosptf changed the title WIP: fixing vulnerability fixing vulnerability: XXE Jul 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants