633: enhancement: set colorspace en fonction des settings au launch d…#643
Open
hfarre wants to merge 3 commits into
Hidden character warning
The head ref may contain hidden characters: "enhancement/633-g\u00e9rer-le-set-de-colorspace-au-lancement-de-psd"
Open
633: enhancement: set colorspace en fonction des settings au launch d…#643hfarre wants to merge 3 commits into
hfarre wants to merge 3 commits into
Conversation
…e psd et quand on open un wf
Staiqzor
reviewed
Jul 10, 2026
| project_name = os.environ['AVALON_PROJECT'] | ||
| project_settings = get_project_settings(project_name) | ||
|
|
||
| colorspace_enabled = project_settings['photoshop']['colorspace'].get('enabled', False) |
Collaborator
There was a problem hiding this comment.
colorspace est ajouté comme clé de settings dans ta PR, ce serait mieux de vérifier via un get que la donnée existe bien avant d'accéder au reste
Collaborator
There was a problem hiding this comment.
(et du coup tu peux stocker ensuite project_settings['photoshop']['colorspace'] dans une variable vu que tu retapes dedans juste après)
Staiqzor
requested changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e psd et quand on open un wf
Automations
Ticket: #633 , Update to: Waiting Deployment